Tweaks for lastPublicKeyId and lastParamsId
#484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cykoder
reviewed
Nov 20, 2024
| @@ -87,6 +87,14 @@ export default class DockInternalAccumulatorModule extends injectParams( | |||
| return (await this.counters(did)).keyCounter; | |||
| } | |||
|
|
|||
| async lastParamsId(did) { | |||
| return await this.paramsCounter(did); | |||
There was a problem hiding this comment.
return await isnt needed, can just return the promise itself. same for lastPublicKeyId
There was a problem hiding this comment.
Without return await in case of an Error, this function won't be included in the stack trace making debugging harder.
There was an eslint rule called no-return-await which is now deprecated, see https://eslint.org/docs/latest/rules/no-return-await and eslint/eslint#17345.
cykoder
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks for
lastPublicKeyIdandlastParamsId