cheqd migration #310
Merged
cheqd migration #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| await createNewWallet(); | ||
| }); | ||
|
|
||
| it('should verify a non ZKP cheqd credential', async () => { |
There was a problem hiding this comment.
do we need one for ZKP too?
There was a problem hiding this comment.
yes, would be good to add one here. I was planning to add zkp with accumulators, but makes sense to have zkp without accumulators too
There was a problem hiding this comment.
We are facing few issues with zkp verification, I will push that test as separate PR probably along with accumulators tests
… feat/cheqd-migration
mike-parkhill
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.