Reduce image size by removing the php source #1043
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've reduced the size of all images by around 10 MB by removing the source code of PHP after compiling it.
To download and delete and the source code again I've added the sub-commands
download
anddelete-download
todocker-php-source
script, which are called whendocker-php-source extract
anddocker-php-source delete
are executed. This allowsdocker-php-ext-install
to work as before.Possible BC breaks:
PHP_URL
was removedFor 1. and 2.
docker-php-source download
must called before anddocker-php-source delete-download
for cleanup must be called after.Of cause the overall build time of the php images increased for most people, but should be acceptable.
I've a quite complex image based on this PHP images and it could be build without problems, so I guess most people won't even notice.