Add -marm to arm32v6 so it can be armv6-from-armv7-compiler instead…
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of armv6-from-armv5-compiler
yosifkit
approved these changes
Mar 14, 2024
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Mar 14, 2024
Changes: - docker-library/hello-world@9421ae1: Merge pull request docker-library/hello-world#114 from infosiftr/marm - docker-library/hello-world@a1c9877: Add `-marm` to arm32v6 so it can be armv6-from-armv7-compiler instead of armv6-from-armv5-compiler
|
Turns out this doesn't actually work on armv6 thanks to the compiler making more assumptions. I'll have a revert soon. |
martin-g
pushed a commit
to martin-g/docker-official-images
that referenced
this pull request
Apr 3, 2024
Changes: - docker-library/hello-world@9421ae1: Merge pull request docker-library/hello-world#114 from infosiftr/marm - docker-library/hello-world@a1c9877: Add `-marm` to arm32v6 so it can be armv6-from-armv7-compiler instead of armv6-from-armv5-compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of armv6-from-armv5-compiler
This is what I wanted originally but hairy error messages about Thumb made it broken and I ran out of steam to fight it.
Thanks @neersighted!! ❤️
The smoking gun from
diffoscope:(our binary compiled the current way is soft-float instead of hard-float like it should've been 🤦)