fix: update tests in seeder

interrupt error caused no coverage to be generated
dnitsch · Feb 13, 2023 · 3ceb1d1 · 3ceb1d1
1 parent a2f0e73
commit 3ceb1d1
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 15 deletions.
diff --git a/seeder/README.md b/seeder/README.md
@@ -44,7 +44,7 @@ basic1:
 
 Strategy is a setting against which to perform one or more rest calls to ensure an idempotent update.
 
-The top level `seed` can contain multiple blo
+The top level `seed` can contain multiple blocks of the below type - `RestAction`
 
 ```yaml
 # the name of the Action is the property itself 
@@ -65,10 +65,6 @@ find-put-post-not-found-id:
     someId: "$.array[?(@.name=='fubar')].id"
 ```
 
-      runtimeVariables:
-        trustedcertificategroups_id: "$.id"
-        highavailabilityprofiles_id: "$.id"
-
 Each Strategy option is defined below, and can be extended.
 
 ### `GET/POST`
@@ -230,10 +226,12 @@ action2:
       someId: "$.array[?(@.name=='fubar')].id"
 ```
 
-### Contribution
+## Contribution
 
 ...
+
 Todo fill me out
+
 ...
-standard go styling and contribution guide lines
 
+standard go styling and contribution guide lines
diff --git a/seeder/auth_test.go b/seeder/auth_test.go
@@ -44,10 +44,10 @@ func TestCustomToken(t *testing.T) {
 		t.Run(name, func(t *testing.T) {
 			got, err := tt.customAuth(t).Token(context.TODO(), tt.client(t), log.New(&bytes.Buffer{}, log.DebugLvl))
 			if err != nil {
-				t.Errorf(testutils.TestPhrase, got, tt.expect)
+				t.Errorf(TestPhrase, got, tt.expect)
 			}
 			if got.TokenValue != tt.expect.TokenValue {
-				t.Errorf(testutils.TestPhraseWithContext, "custom token not returned properly", got.TokenValue, tt.expect.TokenValue)
+				t.Errorf(TestPhraseWithContext, "custom token not returned properly", got.TokenValue, tt.expect.TokenValue)
 			}
 		})
 	}
@@ -79,7 +79,7 @@ func TestClientCredentials(t *testing.T) {
 		t.Run(name, func(t *testing.T) {
 			got := seeder.NewAuth(tt.am)
 			if got == nil {
-				t.Errorf(testutils.TestPhraseWithContext, "auth map", "not nil", "<nil>")
+				t.Errorf(TestPhraseWithContext, "auth map", "not nil", "<nil>")
 			}
 		})
 	}

diff --git a/seeder/rest_test.go b/seeder/rest_test.go
@@ -67,13 +67,13 @@ func Test_findByPathExpression(t *testing.T) {
 			got, err := r.FindPathByExpression(tt.payload, tt.pathExpression)
 			if err != nil {
 				if err.Error() != tt.expect {
-					t.Errorf(testutils.TestPhrase, err, tt.expect)
+					t.Errorf(TestPhrase, err, tt.expect)
 				}
 				return
 			}
 
 			if got != tt.expect {
-				t.Errorf(testutils.TestPhrase, got, tt.expect)
+				t.Errorf(TestPhrase, got, tt.expect)
 			}
 
 		})
@@ -109,7 +109,7 @@ func Test_templatePayload(t *testing.T) {
 
 			got := tt.rest.TemplatePayload(tt.payload, tt.variables)
 			if got != tt.expect {
-				t.Errorf(testutils.TestPhrase, got, tt.expect)
+				t.Errorf(TestPhrase, got, tt.expect)
 			}
 		})
 	}

diff --git a/seeder/seeder_test.go b/seeder/seeder_test.go
@@ -103,7 +103,7 @@ func TestExecute(t *testing.T) {
 					w.Header().Set("Content-Type", "application/json; charset=utf-8")
 					w.Write([]byte(`{"name":"fubar","id":"1234"}`))
 				})
-				mux.HandleFunc("/token", testutils.TokenHandleFunc(t))
+				mux.HandleFunc("/token", TokenHandleFunc(t))
 				return mux
 			},
 			expect: func(url string) error {
@@ -197,7 +197,7 @@ func TestExecute(t *testing.T) {
 					w.Header().Set("Content-Type", "application/json; charset=utf-8")
 					w.Write([]byte(`{"name":"fubar","id":"1234"}`))
 				})
-				mux.HandleFunc("/token", testutils.OAuthPasswordHandleFunc(t))
+				mux.HandleFunc("/token", OAuthPasswordHandleFunc(t))
 				return mux
 			},
 			expect: func(url string) error {