실시간 핫한 후기 UI 구현 및 연동 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
punchdrunkard,
saseungmin,
seokzin and
Zero-1016
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Zero-1016
approved these changes
Aug 25, 2024
| @@ -22,7 +22,7 @@ export interface FiestaResponse<T> { | |||
| data: T; | |||
| } | |||
|
|
|||
| export async function getUserClientSession() { | |||
| export async function getClientSideSession() { | |||
There was a problem hiding this comment.
P5
해당 함수를 따로 분리를 했어야하나? 라는 의문이 있습니다.
import { getSession as getClientSideSession } from "next-auth/react";
로 분리해도 될 것 같기도 하고 그대로 넣어도 상관 없을 것 같습니다!
Comment on lines
+28
to
+31
| images: { | ||
| imageId: 145156, | ||
| imageUrl: "/images/festivalReview.png", | ||
| }, |
There was a problem hiding this comment.
여기 응답 변경있습니다............. 죄송해요 (images 만 thumbnailImage로 string 하나 내려와요)
https://breakyourlimit.notion.site/1159d5ddd66a4aa7a8dc615106f70341?pvs=4
명세 참고해주시고, 그리고 후기 이미지 없는 경우가 있어서 없으면 해당 필드 생략되서 내려올거에요.
(이 부분은 아래에 있군요!)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입 ( 하나 이상의 PR 타입을 선택해주세요 )
개요
백엔드 추가된 엔드포인트와 타입에 따라서 apis에 사전 정의
기존 스토리북에 그려놨던 타입이랑 달라져서 컴포넌트 리팩토링
백엔드에 아직 데이터가 없어서 msw 목데이터 추가
pnpm install && pnpm dev:mock