Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOT 페스티벌 리스트 페이지 구현 #29
HOT 페스티벌 리스트 페이지 구현 #29
Changes from 34 commits
c02a89f
7ff7ebe
87c2dd8
99ae4a9
80d89b5
6e50eb5
c69f568
c48b429
180f353
0488492
d4d4453
2c3aff3
c005f54
1d31c22
552b88e
873b61f
54a1312
d31ff2e
de0c8ff
9ff98df
052a570
c8073ef
9189579
dddff62
d01acab
0eac02c
cd1efce
3030be1
0e4479e
49ef582
4cbac39
ead93b3
d57e318
2320c7b
922da78
db7592b
ac9dd6b
9335b01
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P4
다른 mapping 로직에선 매핑값 네이밍이 festival 등으로 명시 되어있던데
이 부분도 일관성 있게 hotFestival로 네이밍 개선하는 것이 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 리스트 목록들은 모두 같은 festivalModel을 갖고 있어서
festival
로 수정하도록 하겠습니다 ! ㅎㅎ