Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] : test 경로에 설정 파일 추가 #15

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

hyun2371
Copy link
Member

@hyun2371 hyun2371 commented Aug 3, 2024

관련 이슈

📑 작업 상세 내용

  • src/test/resources/applition.yml 생성 후 gitignore에 추가

💫 작업 요약

  • test 경로에 application.yml 추가
  • CI 진행 시 secret에서 application.yml 추출

🔍 중점적으로 리뷰 할 부분

  • 노션에 yml 파일 올려놓았습니다.
  • 기존에는 main 하위 application.yml만 존재해 개발 DB와 테스트 DB가 동일했습니다
    • 기존 테스트에서 ApiTestSupport를 상속 받으면 테스트 컨테이너를 사용할 수 있습니다. (-> 개발 DB와 분리)

@hyun2371 hyun2371 added the 🚨 fix 오류 수정 label Aug 3, 2024
@hyun2371 hyun2371 self-assigned this Aug 3, 2024
@hyun2371 hyun2371 linked an issue Aug 3, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Aug 3, 2024

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 6d01743.

♻️ This comment has been updated with latest results.

@hyun2371 hyun2371 force-pushed the fix/#14/add-test-application-yml branch from 7631a47 to 6d01743 Compare August 3, 2024 06:13
@hyun2371 hyun2371 requested a review from dudxo August 3, 2024 06:14
@hyun2371 hyun2371 changed the title [Fix] test 경로에 설정 파일 추가 [fix] : test 경로에 설정 파일 추가 Aug 3, 2024
@dudxo
Copy link
Collaborator

dudxo commented Aug 3, 2024

CI Test 관련 작업하시느라 고생하셨습니다!

@hyun2371 hyun2371 merged commit cdbb73c into dev Aug 3, 2024
3 checks passed
@hyun2371 hyun2371 deleted the fix/#14/add-test-application-yml branch August 3, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 fix 오류 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚨 test 경로에 설정 파일 추가
2 participants