Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat #4] : 시큐리티 세팅 및 소셜 로그인 API 구현 #13
[feat #4] : 시큐리티 세팅 및 소셜 로그인 API 구현 #13
Changes from 94 commits
23591d7
1a86bf4
be602ff
4c542bb
4a5dab1
87ab12a
8fbffb3
df1d40e
3c65791
4351bf7
e5e4127
00bbd45
546755c
a14d0f7
41665d5
2cdd4b7
e706c88
d3b7fe7
6435102
1859885
d6189ed
60de8a7
e6e2b26
e723028
e314026
55d4697
f658a13
c6c62e9
e7eb2d6
19a3123
33bf7df
4762d46
e8fa553
2492908
9926aa2
449ae2b
004e4ed
147c8d0
037e74c
46ce511
dfeacfc
63594c5
30ca76e
6a2fa1d
8d8cbec
0da91e5
32bf08b
f850cc0
ca4a3d9
043fbdf
320eeed
a304057
7873142
4079520
9234f33
b4f1165
c9d5ce7
0dd84ad
210147b
d7f3332
326d708
271b595
ff3ca70
740a4dd
88b629b
d9403ec
9b68deb
fc4ba01
ab67793
f594720
42a30c0
7c0a8a5
99510b9
d7eb1ad
c4b6e0d
75a63fa
95a5875
90a4ee3
90745c3
9006df8
9bac4dc
1c70ad0
288f1a1
2d1b09b
7e50d2e
4806bcb
e99cf34
8b58c67
adce9d9
e9808eb
2fb8677
f12de11
3f3ae1f
128ce98
250b9ca
b565df1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private으로 되어있는데 Builder로 생성할 수 있나요? 궁금해서 여쭤봅니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이것도 정적 팩토리 메서드의 일종인 것 같은데 다른 enum들처럼 네이밍을 통일해도 괜찮을 것 같습니다! 이 글을 보고 아예 from으로 통일할까도 생각이 드네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
정적 팩토리 메서드에 대해 새로 논의하여 결정된 부분으로 Member, Auth 등 Builder를 통한 객체 생성 -> 정적 팩토리 메서드를 이용한 객체 생성으로 수정했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nullable = false
를 지우신 이유가 있으실까요? 개발하는데 불편하셔서 일까요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지난 논의 사항 때 회원 1자 저장을 위해 officialEmail 필드를 포함한 추가 정보 관련 필드는 null 값 허용을 위해 제거했습니다!
(default nullable =true)