feat: 검색 api를 구현한다. #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 문자열 비교를 통한 검색 기능 구현
rlarltj
approved these changes
Aug 25, 2024
Comment on lines
95
to
96
| booleanBuilder.or(accompanyBoard.title.contains(keyword)); | ||
| booleanBuilder.or(accompanyBoard.content.contains(keyword)); |
There was a problem hiding this comment.
피그마를 봤는데요, title에서만 찾으면 되지 않나요? content까지 포함하면 너무 slow query가 될 것 같아용
# Conflicts: # src/main/java/com/dnd/accompany/domain/accompany/infrastructure/querydsl/AccompanyBoardRepositoryImpl.java # src/main/java/com/dnd/accompany/domain/accompany/infrastructure/querydsl/interfaces/AccompanyBoardRepositoryCustom.java # src/main/java/com/dnd/accompany/domain/accompany/service/AccompanyBoardService.java
|
@rlarltj 혹시 content만 없애면 될까요?? title, tag, region에서 검색하고 있는데, 그냥 title만 검색할까요?? tag는 서브쿼리 써야할 것 같고, title이랑 region은 그렇게 느려지진 않을 것 같아요 |
|
@min429 content만 없애면 될 것 같아요~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 변경 사항
🤔 고민되는 부분