Adapt to rmm 25.02 logger changes #11153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vyasr Does this look correct to you? |
|
Looks like there was a CI fix that went in 2hrs ago: #11167 Would it make sense to merge in latest and see if that addressed some of the CI failures here? |
Didn't notice that was done. Updated! |
vyasr
approved these changes
Jan 14, 2025
|
Thanks Rob 🙏 Looks green! 🥳 @trivialfis when you have a moment, could you please review? 🙂 |
trivialfis
approved these changes
Jan 15, 2025
|
Thanks Jiaming and Vyas for your reviews! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts to breaking changes in rmm in rapidsai/rmm#1722.