[jvm-packages] LTR: distribute the features with same group into same partition #11023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2024
|
Hi @trivialfis, Could you help review it? |
|
@wbo4958 The PR looks good to me. How difficult would it be to run a test with an actual dataset? Would love to see the accuracy as well. Consider the mslr dataset https://github.com/dmlc/xgboost/pull/11007/files . |
trivialfis
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #6713
This PR leverages repartitionByRange to replace repartition for ranking problem, which can guarantee the feature instances in the same group can be distributed into the same partition.