Enabling available subcommands when cli isn't installed #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Available Subcommandsfordlt deploy, including github-action and airflow-composer, are displayed in help even when thedlt[cli]extra is not installed.Related Issues
Additional Context
Basically, now the pipdeptree and cron_descriptor imports in
deploy_command_helpers.pydo not fail, andplugins.pydirectly checks if they can be available in order to decide whether thedeploy_command_availableresolves to True - instead of depending on a ModuleNotFound error that stems from these imports indeploy_command_helpers.py.