-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use selective imports when importing platform-specific modules (core.sys) #20632
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @Reavershark! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#20632" |
d50bc9a
to
ac711b7
Compare
Is this ready for review? (Note that you don't have to do all platforms in one go, incremental work is usually preferred over huge Pull Requests) |
c83f316
to
b54e439
Compare
I think it is. I rebased and will mark this as such once ci finishes.
I'll keep that in mind next time. |
@@ -145,7 +138,7 @@ void main(string[] args) | |||
} | |||
else | |||
{ | |||
import core.sys.posix.dlfcn; | |||
import core.sys.posix.dlfcn : dlopen, RTLD_LAZY, RTLD_NOLOAD; | |||
assert(dlopen(name.ptr, RTLD_LAZY | RTLD_NOLOAD) is null); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not in scope of this Pull Request, but this code is iffy. It assumes that 'not Windows' = posix and imports posix.dlfcn while it used to selectively import RTLD_NOLOAD
from core.sys.{dragonflybsd, linux, netbsd ...}.dlfcn
. It should probably do else version (posix) { dlopen ... } else static assert(0, "unsupported platform")
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, RTLD_NOLOAD
isn't posix, but every platform has it, and rather than being defined in their own core.sys
modules they are all defined in core.sys.posix
with versions and publicly imported into the respective core.sys.platorm
from there. That had me confused. No reason to remove it.
And yes that's one weird version block.
Why
This makes it easier to add support for new platforms to druntime, and maintain platform-specific differences in existing ones. It better reveals the actual dependencies of each module by avoiding implicit public imports.
Progress
This is done for linux and most posix platforms.
Most imports for darwin, solaris and windows are still TODO.
Future work
I'd also like to attempt this with
core.stdc
. That would (in combination with this pr) open up the possibility for developers working with aFreestanding
platform to get parts of druntime to work without needing an entire supported libc, just specific functions.Also, contrary to what druntime assumes, not every platform has concepts like a filesystem, stdio, processes... This could help in determining what modules have those features as hard dependencies, and what modules could also work without them on such platforms.