Handgold and payday rules #3847
Open
+325
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...for handgold -and comments
Loobinex
reviewed
Jan 24, 2025
| @@ -3033,7 +3035,11 @@ short creature_take_salary(struct Thing *creatng) | |||
| internal_set_thing_state(creatng, CrSt_CreatureWantsSalary); | |||
| return 1; | |||
| } | |||
| GoldAmount salary = calculate_correct_creature_pay(creatng); | |||
| // Creature take salary first out of her own pocket | |||
| if(game.conf.rules.game.take_pay_from_pocket || !game.conf.rules.game.accept_partial_payday){ | |||
There was a problem hiding this comment.
why is 'not partial payday' here?
There was a problem hiding this comment.
If allowed with accept_partial_payday,
creatures would take the full salary even if they were already partially paid
There was a problem hiding this comment.
but by accepting partial paydays, you would always take 0 payday next payday on any cash right? So would it not need to be fully excluded before this point?
There was a problem hiding this comment.
This is not about excluding accept_partial_payday, but rather about allowing !accept_partial_payday so that in this case the salary is calculated differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules:
Limits the number of paydays that can be skipped by giving hand gold outside of payday events.
Limits the number of missed paydays that creatures will attempt to claim salary for.
0 = Disables creatures' need for paydays entirely.
When true, any amount of gold is enough to count as a payday and for skipping paydays.
When false, the amount already paid is stored, and the creature will only be satisfied once it reaches 100%.
When true, gold dropped on the creature is stored in their pocket.
When true, creatures first use the gold in their own pocket to satisfy payday.
(can't skip payday if pocket is too small.)
Fixes:
The interaction between these rules should be tested further, both during and outside of payday events.