Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed final newline #219

Conversation

raffaellasuardini
Copy link
Contributor

Updated the editor configurations under Mark's suggestion:

[*.{scss,js,html}]
max_line_length = 120
indent_style = space
insert_final_newline = false
quote_type = double

@raffaellasuardini raffaellasuardini marked this pull request as draft February 8, 2024 17:44
@marksweb
Copy link
Member

marksweb commented Feb 8, 2024

@raffaellasuardini Did you mean to close this? This looks like something we had talked about doing?

@raffaellasuardini
Copy link
Contributor Author

@marksweb I made the changes but I made it on the wrong branch

@marksweb
Copy link
Member

marksweb commented Feb 9, 2024

@raffaellasuardini Ah ok, well if you create a PR against the wrong branch, you can change where it's target is. But if you started a branch from the wrong branch and still have the changes from this PR, you can start a new branch and cherry-pick the commits from the original branch onto the correct one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants