Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.4.2 merge? #72

Merged
merged 47 commits into from
Aug 19, 2024
Merged

3.4.2 merge? #72

merged 47 commits into from
Aug 19, 2024

Conversation

dj1ch
Copy link
Owner

@dj1ch dj1ch commented Aug 19, 2024

No description provided.

@github-actions github-actions bot mentioned this pull request Aug 19, 2024
size_t required_size = 0;
err = nvs_get_str(cfgHandle, "whitelist", NULL, &required_size);
if (err == ESP_OK && required_size > 0) {
char *whitelistStr = (char *)malloc(required_size);

Check notice

Code scanning / devskim

If the value provided to malloc is the result of unsafe integer math, it can result in an exploitable condition. Note

Problematic C function detected (malloc)
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
@dj1ch
Copy link
Owner Author

dj1ch commented Aug 19, 2024

how many pull requests is this going to take 💀

@github-actions github-actions bot mentioned this pull request Aug 19, 2024
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
@dj1ch
Copy link
Owner Author

dj1ch commented Aug 19, 2024

im done.

@dj1ch dj1ch merged commit 7fd6097 into main Aug 19, 2024
2 of 3 checks passed
dj1ch added a commit that referenced this pull request Aug 19, 2024
Merge pull request #72 from dj1ch/development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants