You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current implementation writes conditional styles directly, with !important is only way to override them.
As !important flag is a bad practice, it would be a lot easier to style table with at least conditional classes and having an option to override default table stylesheet.
The text was updated successfully, but these errors were encountered:
I agree completely. That's something that bugged me in my use cases for the smart table as well.
I carefully mark this as a breaking change, though, because there might be users who already depend on the way it was implemented by the original authors. But I can imagine that there is actually a compatible way to move the inline styles to proper css classes without breaking anything (if everyone was forced to use !important anyway, it shouldn't be a big deal, but who knows). That's not so easy to verify imho. But if we can do that, the label can of course be removed.
Current implementation writes conditional styles directly, with !important is only way to override them.
As !important flag is a bad practice, it would be a lot easier to style table with at least conditional classes and having an option to override default table stylesheet.
The text was updated successfully, but these errors were encountered: