Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of inline styles. #98

Open
maximLyakhov opened this issue Aug 19, 2022 · 1 comment
Open

Get rid of inline styles. #98

maximLyakhov opened this issue Aug 19, 2022 · 1 comment
Labels
breaking-change Resolving this issue will introduce a breaking change. enhancement New feature or request

Comments

@maximLyakhov
Copy link

Current implementation writes conditional styles directly, with !important is only way to override them.
As !important flag is a bad practice, it would be a lot easier to style table with at least conditional classes and having an option to override default table stylesheet.

@uap-universe uap-universe added enhancement New feature or request breaking-change Resolving this issue will introduce a breaking change. labels Aug 19, 2022
@uap-universe
Copy link
Collaborator

uap-universe commented Aug 19, 2022

I agree completely. That's something that bugged me in my use cases for the smart table as well.

I carefully mark this as a breaking change, though, because there might be users who already depend on the way it was implemented by the original authors. But I can imagine that there is actually a compatible way to move the inline styles to proper css classes without breaking anything (if everyone was forced to use !important anyway, it shouldn't be a big deal, but who knows). That's not so easy to verify imho. But if we can do that, the label can of course be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Resolving this issue will introduce a breaking change. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants