Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal "selected" style for a row overrides possible customer styles, forcing them to use !important #169

Closed
uap-universe opened this issue Dec 9, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@uap-universe
Copy link
Collaborator

Here

<tr (click)="userSelectRow.emit(row)" (mouseover)="rowHover.emit(row)" class="angular2-smart-row" [className]="rowClassFunction(row)" [ngClass]="{selected: row.isSelected}">

and here

a style for selected rows is applied.

But this is conflicting with a possible user defined style (provided by the configured row class), forcing them to always use !important in their row class.

@uap-universe uap-universe added the bug Something isn't working label Dec 9, 2024
@uap-universe uap-universe self-assigned this Dec 10, 2024
@uap-universe uap-universe modified the milestone: v3.5.0 Dec 10, 2024
@uap-universe
Copy link
Collaborator Author

Relates to #98

It is probably impossible to fix this without a complete redesign on how things in the smart table are supposed to be styled.

This is due to the nature of CSS and how it works. Nothing we can do right now.

@uap-universe uap-universe closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant