Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update itsdangerous restriction to ~=2.0 #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ralequi
Copy link

@ralequi ralequi commented Jul 6, 2021

This may help (or even fix, dunno yet) issue #55

Why should we upgrade itsdangerous package?

  • From my point of view there is no reason not to do so, but for possible compatibility reasons. The package that should restrict it is webservices but does not impose any restriction
  • It seems there may be other packages that may require a greater version. This may cause an incompatibility issue.
  • It seems that the version itself does not matter at all while both, client & server keeps the same version installed

Why we should not remove every restriction on the package and leave to webservices package?

  • It seems that there were some break changes in earlier versions.
  • It may help to have some "greater" version pinning, as it may force to keep the same version range on both: client and server.

So why version ~2.0 ? (It's equivalent to >=2.0, <3.0)

  • There is no really a great reason for this. ~1.0 may work perfectly.
  • Maybe the best argument to put ~2.0 instead of ~1.0 is to try to keep that restriction as updated as we could.

@GaretJax
Copy link
Contributor

Thanks for the PR @ralequi. Sadly we need a way to keep the pre-1.0 generated signature format for compatibility with clients that we do not have control on.
Maybe vendoring in the dependency would be a better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants