Task implemented #38
Open
Task implemented #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- composer requirements added - phpunit configurated - run-tests.bat, run-tests.sh added
- unit tests added - Services/DivisionService.php stub added
- code written - tests passed
- Qix added to tests
- test refactored and modified - code to DivisionService.php added
- DivisionService renamed to NumberService - DivisionService::run renamed to NumberService::multiples
- run-tests.bat modified allow run with arguments - tests for occurances added - three tests for NumberService added
- new method occurrences implemented - new method multiplesAndOccurrences implemented - tests passed https://github.com/divigrupa/FooBarQixExtended/blob/master/step_3.md
- Service renamed - Tests renamed - Tests passed
- new service InfQixFoo added - test for methods: multiples, occurrences implemented
- methods occurrences and multiples added
- new methods sum(), resetSum() added - tests implemented
- method sum() and resetSum() implemented - tests passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All complete