Toms Bēmis #37
Open
Toms Bēmis #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MultiplesService.php with one function that always returns null; - Tests that go through arranging step but fail asserting; - (DEV) downgraded PHPUnit to solve "ReflectionClass::getMethods() expects" error.
- expect the input number in the result, to see which number causes errors; - sorting the first two multipliers in combined_multiple_test; - converting expected results to arrays.
- multiples function validates input; - returns all the multiplier outputs if input is 0; - returns one or many multiplier outputs of input number is a multiple; - returns input number if it is not a multiple of any of the multipliers.
- Added new multiplier and expected output in automated tests; - Assertion fails when running single_multiple_test with multiplier 7; - Assertion fails when running combined_multiple_test (new multiplier output is missing from array).
- OccurrencesService.php with one function that always returns null; - Tests that go through arranging step but fail asserting.
MultiplesService and OccurrencesService extends NumberService to use the same input number validation.
- occurrences function validates input; - returns all the transformations if any of the digits of input number match the defined transformations.
…ses the same property. The service is the one place the transformations need to be edited when something changes.
… uses the same property. The service is the one place the transformations need to be edited when something changes.
- New PositiveIntegerValidator for parent class; - MultiplesService and OccurrencesService can skip validation if the methods are used in an instance that does the validation (avoiding validation multiple times); - Step3Test.php unused values removed.
- Feature test for IntegratedNumberService that fails asserting because of missing implementation; - IntegratedNumberService for combining Multiples and Occurrences.
- multiples_and_occurrences function returns valid and tested results; - multiples_and_occurrences_test fix (for loop upper bound mistake).
- MultiplesService and OccurrencesService contains methods, while child classes contains key value pairs for transformations; - New child classes for services (Multiples and Occurrences services for both FooBarQix and InfQixFoo steps); - IntegratedNumberService contains methods, while child classes contains specific service integrations (FooBarQixIntegratedNumberService integrates FooBarQix services and so on); - MultiplesTest and OccurrencesTest contains tests, while child classes initialize correct service in setUp; - New child tests for each step (MultiplesTest and OccurrencesTest for both FooBarQix and InfQixFoo steps); - IntegratedNumberServiceTest contains tests, while child classes only set up the associated services. MultiplesTest no_transformation_test checks if the multiplier 1 exists to avoid risky tests without assertions. MultiplesService and their children constructor sorts and reassigns the multiplier keys.
… Changing accessibility for IntegratedNumberServiceTest method contains_all_transform_digits (private -> protected).
- InfQixFoo outputs are strings with semicolon separator; - Duplicate code fragments, needs refactoring; - Tests pass.
- Duplicate code fragments removed; - Service and test parent classes have 'separator' property; - Service parent classes check for separator before formatting output; - Test parent classes check for separator before asserting expected output.
- OccurrencesTest removes digits that are at the same time digit sum multipliers; - New property for InfQixFooIntegratedNumberService which associates digit sum multiplier with suffix to append at the end of the result; - New tests for InfQixFooIntegratedNumberService that fail asserting because the service is missing implementation that appends suffix.
- New method for InfQixFooIntegratedNumberService, which uses output of multiples_and_occurrences and then modifies the result; - InfQixFooIntegratedNumberServiceTest tests both inherited method and the new method for appending suffix at the end of output.
- New composer scripts for regular testing and testing with code coverage; - Code coverage report "High".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.