Feature Branch #30
Open
Feature Branch #30
+338
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I feel like there is no need to instantiate this FooBarQix class so I made the method a static one.
Since the tests were basically the same everytime, only the values changed, I decided to use data providers. Plus I wrote more tests just to be sure.
…ch expected result in the tests.
…new line of code to make like a dozen tests pass
…der which checks whether the strings are appended correctly. Then I added another data provider, which checks whether it works together with the previous functionality.
…tring, and checking the multiples + appending the string.
…ike FooBarQix, but, of course, with different test cases.
…rs writing the tests, so I fixed them. The main InfQixFoo class is almost the same as FooBarQix except the definitions and the separator.
… tests are green and there is nothing left to check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presenting my homework for the FooBarQixExtended task. I did not make the code coverage, because something just did not want to work for me in the config files, so I am submitting without it. Hope this will not impact your decision too much. This was a lot of fun and I hope you will like my solution to this problem. I will be awaiting feedback!