Add *working* sar binary data indexing support #645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes distributed-system-analysis#227 sysstat updates: - cover error patterns and version check - add support for 0x2173 in sysstat Add TODO task lists as comments in extract_sa.py Add unit tests for sar ingress under 'test-7.10' Also: - fix existing unit tests for this branch - update line no.s for gold test 7.{3..5}. Refer distributed-system-analysis#303 - update .gitignore: __pycache__ in any dir - cleanup sar-index code addition
ndokos
requested changes
Aug 22, 2017
arcolife
reviewed
Jan 9, 2018
|
|
||
| # Do we need a test to see if DEFAULT_SADF_PATH not present, | ||
| # whereas binaries path contains the scripts needed to process? | ||
| # Idk, since pbench-sysstat is installed de-facto. |
There was a problem hiding this comment.
@portante should we be adding that test for DEFAULT_SADF_PATH in a separate PR or have this amended in the current one? The modifications done by you to extract_sa.py would end up being useful for https://github.com/distributed-system-analysis/sarjitsu
Also, how do we plan on maintaining these 2 copies of extract_sa.py? (one in pbench, other in sarjitsu, and actually another in https://github.com/distributed-system-analysis/satools/blob/master/satools/extractsa.py).
Related: distributed-system-analysis/satools#1
thanks for the rework btw :-)) apologies for not being able to review this earlier. Working on my new year resolutions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227, replaces #176.
sysstat updates:
Add TODO task lists as comments in extract_sa.py
Add unit tests for sar ingress under 'test-7.10'
Also: