Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔑 Change unspendable key to hash of X of G #24

Merged
merged 1 commit into from
Oct 28, 2024
Merged

🔑 Change unspendable key to hash of X of G #24

merged 1 commit into from
Oct 28, 2024

Conversation

Velnbur
Copy link
Collaborator

@Velnbur Velnbur commented Oct 28, 2024 •
edited
Loading

🔍 Objective

The current implementation uses the X-only key of some random private key, which is unacceptable for protocol.

🔧 Fixed/Updated

Change UNSPENDABLE_KEY constant to the hash of X of generator point.

✅ Checklist

  • PR title corresponds to the body of changes.
  • PR has a proper label, assignee, and reviewers.
  • Tests that cover the changes are added (if needed).
  • Documentation (README files, paper) and Code Comments are updated accordingly.
  • Code is formatted, all tests pass, and CI shows no errors.

@Velnbur Velnbur added the bug Something is not working label Oct 28, 2024
@Velnbur Velnbur requested a review from ZamDimon October 28, 2024 07:52
@Velnbur Velnbur self-assigned this Oct 28, 2024
@Velnbur Velnbur changed the title Change unspendable key to hash of X of G Change unspendable key to hash of $X$ of $G$ Oct 28, 2024
@Velnbur Velnbur changed the title Change unspendable key to hash of $X$ of $G$ Change unspendable key to hash of X of G Oct 28, 2024
ZamDimon
ZamDimon approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@ZamDimon ZamDimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, seems totally legit

@ZamDimon ZamDimon changed the title Change unspendable key to hash of X of G 🔑 Change unspendable key to hash of X of G Oct 28, 2024
@Velnbur Velnbur merged commit f072f92 into main Oct 28, 2024
4 checks passed
@Velnbur Velnbur deleted the unspendable-taproot-key branch October 28, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZamDimon ZamDimon ZamDimon approved these changes

Assignees

@Velnbur Velnbur

Labels
bug Something is not working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velnbur @ZamDimon