🌱 Add constant seeds for integration tests and demo CLI (#26)

# 🔍 Objective

As before the behavior of integration tests for "disprove" spending
checks was random, the CI sometimes didn't pass as the algorithm may
create too large blocks or the script caused the "Stack limit exceeds"
error, which wasn't a problem as integration tests only checked the
"spending" behavior and bugs will be fixed later.

## 🆕 Added

Constant seeds for integration tests and demo CLI for distorted states.

core/src/assert/mod.rs

@@ -16,8 +16,8 @@ use bitcoin::{
 use bitcoin_splitter::split::script::SplitableScript;
 
 use crate::{
-    assert::payout_script::PayoutScript, disprove::form_disprove_scripts_distorted, treepp::*,
-    UNSPENDABLE_KEY,
+    assert::payout_script::PayoutScript, disprove::form_disprove_scripts_distorted_with_seed,
+    treepp::*, UNSPENDABLE_KEY,
 };
 
 use crate::disprove::{form_disprove_scripts, DisproveScript};
@@ -105,13 +105,18 @@ impl<const I: usize, const O: usize, S: SplitableScript<I, O>> AssertTransaction
         }
     }
 
-    pub fn with_options_distorted(
+    pub fn with_options_distorted<
+        Seed: Sized + Default + AsMut<[u8]> + Copy,
+        Rng: rand::SeedableRng<Seed = Seed> + rand::Rng,
+    >(
         input: Script,
         operator_pubkey: XOnlyPublicKey,
         amount: Amount,
         options: Options,
+        seed: Seed,
     ) -> (Self, usize) {
-        let (disprove_scripts, idx) = form_disprove_scripts_distorted::<I, O, S>(input.clone());
+        let (disprove_scripts, idx) =
+            form_disprove_scripts_distorted_with_seed::<I, O, S, Seed, Rng>(input.clone(), seed);
         let payout_script = PayoutScript::with_locktime(operator_pubkey, options.payout_locktime);
         (
             Self {

integration-tests/src/taproot.rs

@@ -3,7 +3,7 @@ use std::{env, fs, str::FromStr as _};
 use bitcoin::{
     consensus::{Decodable, Encodable as _},
     io::Cursor,
-    key::Secp256k1,
+    key::{rand::rngs::SmallRng, Secp256k1},
     relative::Height,
     secp256k1::{All, PublicKey, SecretKey},
     Address, Amount, CompressedPublicKey, Network, OutPoint, Transaction, TxOut, Txid,
@@ -129,6 +129,10 @@ fn test_script_payout_spending<const I: usize, const O: usize, S>() -> eyre::Res
 where
     S: SplitableScript<I, O>,
 {
+    // Approximate amount of satoshis to fullfill the fees for all
+    // transactions in tests.
+    const APPROX_TXOUT_AMOUNT: u64 = 71_000;
+
     let TestSetup {
         ctx,
         client,
@@ -138,13 +142,13 @@ where
         funding_txout,
         funder_address,
         ..
-    } = setup_test::<I, O, S>(71_000)?;
+    } = setup_test::<I, O, S>(APPROX_TXOUT_AMOUNT)?;
 
     let operator_xonly = OPERATOR_PUBKEY.x_only_public_key().0;
     let assert_tx = AssertTransaction::<{ I }, { O }, S>::with_options(
         input_script,
         operator_xonly,
-        Amount::from_sat(70_000),
+        Amount::from_sat(APPROX_TXOUT_AMOUNT - 1_000),
         Options {
             payout_locktime: Height::from(1),
         },
@@ -165,7 +169,7 @@ where
     let payout_tx = assert_tx.payout_transaction(
         &ctx,
         TxOut {
-            value: Amount::from_sat(69_000),
+            value: Amount::from_sat(APPROX_TXOUT_AMOUNT - 2_000),
             script_pubkey: funding_txout.script_pubkey,
         },
         OutPoint::new(atx.compute_txid(), 0),
@@ -184,6 +188,10 @@ fn test_script_disprove_distorted<const I: usize, const O: usize, S>() -> eyre::
 where
     S: SplitableScript<I, O>,
 {
+    // Approximate amount of satoshis to fullfill the fees for all
+    // transactions in tests.
+    const APPROX_TXOUT_AMOUNT: u64 = 100_000;
+
     let TestSetup {
         ctx,
         client,
@@ -193,17 +201,20 @@ where
         funding_txout,
         funder_address,
         ..
-    } = setup_test::<I, O, S>(100_000)?;
+    } = setup_test::<I, O, S>(APPROX_TXOUT_AMOUNT)?;
 
     let operator_xonly = OPERATOR_PUBKEY.x_only_public_key().0;
-    let (assert_tx, distored_idx) = AssertTransaction::<{ I }, { O }, S>::with_options_distorted(
-        input_script,
-        operator_xonly,
-        Amount::from_sat(90_000),
-        Options {
-            payout_locktime: Height::from(1),
-        },
-    );
+    let (assert_tx, distored_idx) =
+        AssertTransaction::<{ I }, { O }, S>::with_options_distorted::<[u8; 32], SmallRng>(
+            input_script,
+            operator_xonly,
+            // remove 10% from amount to fulfill the fee
+            Amount::from_sat(APPROX_TXOUT_AMOUNT * 9 / 10),
+            Options {
+                payout_locktime: Height::from(1),
+            },
+            [1; 32],
+        );
 
     let atx = assert_tx.clone().spend_p2wpkh_input_tx(
         &ctx,
@@ -220,7 +231,10 @@ where
     let disprove_txs = assert_tx.clone().disprove_transactions(
         &ctx,
         TxOut {
-            value: Amount::from_sat(9_000),
+            // take only 10% percent and leave other for the fee.
+            // This values is euristic and should calculated by
+            // ourself instead in future.
+            value: Amount::from_sat(APPROX_TXOUT_AMOUNT / 10),
             script_pubkey: funding_txout.script_pubkey,
         },
         OutPoint::new(atx.compute_txid(), 0),
@@ -245,7 +259,7 @@ where
 }
 
 #[test]
-#[ignore = "Stack size limit exceeded"]
+#[ignore = "tx-size"]
 fn test_u254_mul_disprove() -> eyre::Result<()> {
     color_eyre::install()?;
     tracing_subscriber::fmt().init();
@@ -269,12 +283,14 @@ fn test_u254_mul_payout() -> eyre::Result<()> {
 
 #[test]
 fn test_square_fibonachi() -> eyre::Result<()> {
+    const FIB_STEPS: usize = 1024;
+
     color_eyre::install()?;
     tracing_subscriber::fmt().init();
     test_script_disprove_distorted::<
-        { SquareFibonacciScript::<1024>::INPUT_SIZE },
-        { SquareFibonacciScript::<1024>::OUTPUT_SIZE },
-        SquareFibonacciScript<1024>,
+        { SquareFibonacciScript::<FIB_STEPS>::INPUT_SIZE },
+        { SquareFibonacciScript::<FIB_STEPS>::OUTPUT_SIZE },
+        SquareFibonacciScript<FIB_STEPS>,
     >()
 }
 

nero-cli/src/cli/actions.rs

@@ -5,7 +5,7 @@ use bitcoin::{
     consensus::{Decodable, Encodable},
     hashes::Hash,
     io::Cursor,
-    key::rand::thread_rng,
+    key::rand::{rngs::SmallRng, thread_rng},
     secp256k1::SecretKey,
     Address, Amount, Network, OutPoint, ScriptBuf, Transaction, TxOut, Txid, XOnlyPublicKey,
 };
@@ -44,12 +44,17 @@ pub fn assert_tx(ctx: Context, args: AssertTxArgs) -> eyre::Result<()> {
     let opts = Options::default();
 
     // FIXME(Velnbur): make this optionally valid
-    let (assert, invalid_chunk_idx) =
-        AssertTransaction::<
-            { SquareFibonacciScript::<1024>::INPUT_SIZE },
-            { SquareFibonacciScript::<1024>::OUTPUT_SIZE },
-            SquareFibonacciScript<1024>,
-        >::with_options_distorted(input_script, args.pubkey, args.amount, opts);
+    let (assert, invalid_chunk_idx) = AssertTransaction::<
+        { SquareFibonacciScript::<1024>::INPUT_SIZE },
+        { SquareFibonacciScript::<1024>::OUTPUT_SIZE },
+        SquareFibonacciScript<1024>,
+    >::with_options_distorted::<[u8; 32], SmallRng>(
+        input_script,
+        args.pubkey,
+        args.amount,
+        opts,
+        [1; 32],
+    );
 
     let assert_output_address = Address::from_script(
         &assert.txout(ctx.secp_ctx()).script_pubkey,