Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PER-10: Added new search index field for image discovery #20

Merged
merged 5 commits into from
Mar 6, 2024
Merged

PER-10: Added new search index field for image discovery #20

merged 5 commits into from
Mar 6, 2024

Conversation

axelerant-hardik
Copy link
Contributor

@axelerant-hardik axelerant-hardik commented Feb 20, 2024 •
edited
Loading

No description provided.

@axelerant-hardik axelerant-hardik marked this pull request as draft February 20, 2024 13:20
adam-vessey
adam-vessey reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@adam-vessey adam-vessey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually ready for review? It's still marked "draft".

src/Plugin/search_api/processor/IslandoraObjectImageDiscovery.php Outdated Show resolved Hide resolved
src/Plugin/search_api/processor/IslandoraObjectImageDiscovery.php Outdated Show resolved Hide resolved
src/Plugin/search_api/processor/IslandoraObjectImageDiscovery.php Outdated Show resolved Hide resolved
@axelerant-hardik
Copy link
Contributor Author

Is this actually ready for review? It's still marked "draft".

I have marked as Draft since I am not able to add labels like do not merge to this PR. There would be eventually updates to the view's rewrite results I reckon to fit in Morgan's styling changes.

@axelerant-hardik axelerant-hardik marked this pull request as ready for review February 22, 2024 13:18
@axelerant-hardik axelerant-hardik changed the title PER-10: Draft - Added new search index field for image discovery PER-10: Added new search index field for image discovery Feb 22, 2024
@adam-vessey adam-vessey added the minor Added functionality that is backwards compatible. label Feb 26, 2024
@nchiasson-dgi nchiasson-dgi merged commit ca4768f into discoverygarden:main Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-vessey adam-vessey adam-vessey approved these changes

Assignees
No one assigned
Labels
minor Added functionality that is backwards compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axelerant-hardik @adam-vessey @nchiasson-dgi