DDST-229: Add spreadsheet alter.

[chrismacdonaldw]

No description provided.

[adam-vessey]

A little spooked by the direct/blind overwrite here. Assertions of some sort might be in order, to make sure that what we're stomping on is what is expect, in case the upstream migration changes in some manner.

[adam-vessey]

Better structure of data could make things much more legible:

Suggested change

	// Add Text (plain) delimited fields.
	$fields_to_add = [
	['field_local_contexts', 'local_contexts', ';'],
	['field_access_id', 'access_id', ';'],
	];
	foreach ($fields_to_add as $field) {
	$process[$field[0]] = [
	[
	'plugin' => 'skip_on_empty',
	'source' => $field[1],
	'method' => 'process',
	],
	[
	'plugin' => 'dgi_migrate.process.explode',
	'delimiter' => $field[2],
	],
	[
	'plugin' => 'skip_on_empty',
	'method' => 'row',
	'message' => 'Empty ' . $field[1] . '.',
	],
	];
	}
	// Add Text (plain) delimited fields.
	$fields_to_add = [
	'field_local_contexts' => ['local_contexts', ';'],
	'field_access_id' => ['access_id', ';'],
	];
	foreach ($fields_to_add as $field => $info) {
	[$source, $delimiter] = $info;
	$process[$field] = [
	[
	'plugin' => 'skip_on_empty',
	'source' => $source,
	'method' => 'process',
	],
	[
	'plugin' => 'dgi_migrate.process.explode',
	'delimiter' => $delimiter,
	],
	[
	'plugin' => 'skip_on_empty',
	'method' => 'row',
	'message' => 'Empty ' . $source . '.',
	],
	];
	}

[adam-vessey]

Unsure about the specific message here: The issue is not that it's empty, per-se, as we're fine when it's empty, skipping the processing up front, but that the source value contained only delimiters (and maybe whitespace that was trimmed?).

Maybe something like:

Suggested change

	'message' => 'Empty ' . $field[1] . '.',
	'message' => "No usable values in {$field[1]}.",

(but would change if adopting the more specific variable names, whatever)

[adam-vessey]

Not sure where to comment on exactly, but I'm thinking we should generally avoid the variable reuse across these bigger functions.

More specific names, with more specific structures should help future readability.

[adam-vessey]

I think we're kind of in the same "no useful value" case here?

[adam-vessey]

Same kind of "no useful value" case here?