Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: attempt the postgresql update if a stale socket file exists #935

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

mwaniki-wairungu
Copy link
Contributor

@mwaniki-wairungu mwaniki-wairungu commented Feb 3, 2025

If there is a stale socket file when bumping the database version, the current workflow throws spurious errors because of this line in the install_postgres script:

socat /dev/null UNIX-CONNECT:/shared/postgres_run/.s.PGSQL.5432 || exit 0 && echo postgres already running stop container ; exit 1

With this change:

  • If postgres is still running, the current behaviour remains the same.
  • If postgres was not shut down cleanly, pg_upgrade returns that error.
  • If it's just a stale file, pg_upgrade should continue to run.

If postgres was not shut down cleanly, pg_upgrade returns that error.

If it's just a stale file, pg_upgrade should continue to run.
@mwaniki-wairungu mwaniki-wairungu merged commit 98f470f into main Feb 3, 2025
5 checks passed
@mwaniki-wairungu mwaniki-wairungu deleted the pg15_socket_error_fix branch February 3, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants