Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Various improvements to UI #36

Merged
merged 23 commits into from
Dec 18, 2023
Merged

UX: Various improvements to UI #36

merged 23 commits into from
Dec 18, 2023

Conversation

davidtaylorhq
Copy link
Member

No description provided.

davidtaylorhq and others added 17 commits November 25, 2023 09:38
(core added a backwards-compat shim for the controller)
Before we only showed top-level topic assignments on cards,
but this was misleading because topics which only had posts
assigned would appear to be not assigned at all
If set to "detailed", the last poster for the topic will
be shown on the cards
Move last poster username and relative date to bottom
left and represent assigned users with avatars in bottom
right
Arkshine added a commit to Arkshine/discourse-kanban-theme that referenced this pull request Nov 25, 2023

export default class KanbanNav extends Component {
<template>
<li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button should be rendered based on the display_categories setting.

This is a change forgotten from the old code which was using a connector:

shouldRender(args) {
  return displayConnector(args.category?.get("slug"));
},

common/common.scss Outdated Show resolved Hide resolved
@janzenisaac janzenisaac force-pushed the ui-overhaul branch 2 times, most recently from 232692b to d7efab7 Compare December 18, 2023 18:03
@janzenisaac janzenisaac marked this pull request as ready for review December 18, 2023 18:19
settings.yml Outdated Show resolved Hide resolved
Copy link
Member Author

@davidtaylorhq davidtaylorhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janzenisaac janzenisaac merged commit bcf2df8 into main Dec 18, 2023
4 checks passed
@janzenisaac janzenisaac deleted the ui-overhaul branch December 18, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants