-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Various improvements to UI #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(core added a backwards-compat shim for the controller)
Before we only showed top-level topic assignments on cards, but this was misleading because topics which only had posts assigned would appear to be not assigned at all
If set to "detailed", the last poster for the topic will be shown on the cards
Move last poster username and relative date to bottom left and represent assigned users with avatars in bottom right
davidtaylorhq
force-pushed
the
ui-overhaul
branch
from
November 25, 2023 09:39
fc6f772
to
94492f8
Compare
Arkshine
added a commit
to Arkshine/discourse-kanban-theme
that referenced
this pull request
Nov 25, 2023
Imported from discourse#36
Arkshine
reviewed
Nov 25, 2023
Arkshine
reviewed
Nov 25, 2023
Arkshine
reviewed
Nov 25, 2023
|
||
export default class KanbanNav extends Component { | ||
<template> | ||
<li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button should be rendered based on the display_categories
setting.
This is a change forgotten from the old code which was using a connector:
shouldRender(args) {
return displayConnector(args.category?.get("slug"));
},
Arkshine
reviewed
Nov 27, 2023
javascripts/discourse/initializers/initialize-discourse-kanban.js
Outdated
Show resolved
Hide resolved
Arkshine
reviewed
Nov 27, 2023
Arkshine
reviewed
Nov 27, 2023
davidtaylorhq
commented
Dec 18, 2023
davidtaylorhq
commented
Dec 18, 2023
davidtaylorhq
commented
Dec 18, 2023
janzenisaac
force-pushed
the
ui-overhaul
branch
2 times, most recently
from
December 18, 2023 18:03
232692b
to
d7efab7
Compare
janzenisaac
force-pushed
the
ui-overhaul
branch
from
December 18, 2023 18:08
42bcbf3
to
3f37770
Compare
janzenisaac
force-pushed
the
ui-overhaul
branch
from
December 18, 2023 18:13
3f149b7
to
21db0da
Compare
davidtaylorhq
commented
Dec 18, 2023
davidtaylorhq
commented
Dec 18, 2023
davidtaylorhq
commented
Dec 18, 2023
janzenisaac
force-pushed
the
ui-overhaul
branch
from
December 18, 2023 21:33
2e07925
to
ff99d76
Compare
davidtaylorhq
commented
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
janzenisaac
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.