-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lock/unlock method to Thread class #1240
base: master
Are you sure you want to change the base?
Conversation
Not entirely sure how I ended up running |
Other maintainers have argued that functions like this, which aren't directly documented by Discord, make the overall library harder to maintain. My primary question when reviewing this PR (and the Thread class in general) is: why doesn't the Channel class have a similar rename method using the patch endpoint, as the Thread class does? While I don't share the opinion that such functions complicate maintenance, it does suggest that these features might be better implemented as a shared trait among similar classes. I believe this PR is appropriate because it addresses a thread-specific issue (locking and unlocking) that doesn't apply to other contexts, so unless someone objects I am 100% for merging this. |
I'm with you having functions like this or common ones shared as a class trait is a good thing. As long as it's possible to do something and it's not completely unintended like modals having dropdowns, then having that functionality helps everyone. |
I messed up my PR/commit 🤦 My changes to the CommandBuilder were meant to go separate. I'm awful with Git, any advice would be appreciated to solve this 🙏 |
Undo your command builder changes here and re-push. Afterwards, checkout back to the main branch of your fork using |
I'll give that a go tomorrow. Thank you! |
I didn't realize you did this PR off of |
You should just create a new branch in your repository then cherry pick the latest commit. And then create new PR
For case in Thread, there exists method Locked and unlocked did not have its own method because at that time you can just do |
Adds ability to lock/unlock threads using the Thread class.