Entitlements updates #1186
Open
Entitlements updates #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
key2peace
commented
Oct 20, 2023
•
key2peace
commented
- awaits Update InteractionResponseType.php discord/discord-interactions-php#8
since it is linked, things should be easier
since it is linked, things should be easier
use get instead of cacheget
use get instead of cacheGet
Change endpoints
SQKo
requested changes
Oct 22, 2023
| if ($entitlementPart = $this->discord->application->entitlements->get('id', $entitlement->id)) { | ||
| $entitlementPart->fill((array) $entitlement); | ||
| } else { | ||
| $this->discord->application->entitlements->set($entitlement->id, $this->discord->application->entitlements->create($entitlement, true)); |
There was a problem hiding this comment.
Since it's not available in my region, I just want to be sure that the entitlement received here is ONLY the entitlement belongs to the bot's application, and not to other's application (can you compare for application_id first to be safe?)
There was a problem hiding this comment.
as per https://discord.com/developers/docs/monetization/entitlements#entitlement-resource thats already the case
Co-authored-by: SQKo <[email protected]>
Co-authored-by: SQKo <[email protected]>
Co-authored-by: SQKo <[email protected]>
Co-authored-by: SQKo <[email protected]>
Co-authored-by: SQKo <[email protected]>
Co-authored-by: SQKo <[email protected]>
SQKo
requested changes
Nov 4, 2023
src/Discord/Parts/Guild/Guild.php
Outdated
Comment on lines
1596
to
1602
| * @link https://discord.com/developers/docs/monetization/entitlements#list-entitlements | ||
| * | ||
| * @return Collection[]|Entitlement[] | ||
| */ | ||
| public function getMyApplicationEntitlement(): Collection | ||
| { | ||
| return $this->discord->application->entitlements->get('guild_id', $this->id); |
src/Discord/Parts/User/User.php
Outdated
Comment on lines
296
to
300
| * @return Collection[]|Entitlement[] | ||
| */ | ||
| public function getMyApplicationEntitlement(): Collection | ||
| { | ||
| return $this->discord->application->entitlements->get('user_id', $this->id); |
SQKo
requested changes
Nov 4, 2023
| * with this source code in the LICENSE.md file. | ||
| */ | ||
|
|
||
| namespace Discord\Parts\Interactions; |
| * with this source code in the LICENSE.md file. | ||
| */ | ||
|
|
||
| namespace Discord\Repository\Interaction; |
SQKo
reviewed
Nov 4, 2023
| $entitlementPart = $oldEntitlement; | ||
| $oldEntitlement = clone $oldEntitlement; | ||
|
|
||
| $entitlementPart->fill((array) $data); |
|
I believe this now needs to be re-reviewed and the 'wait for discord' label removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.