Implement AudioPacketInterceptor #425
Conversation
| @@ -258,28 +266,33 @@ else if (sendHandler == null && sendSystem != null) | |||
|
|
|||
| private synchronized void setupReceiveSystem() | |||
| { | |||
There was a problem hiding this comment.
The current implementation initializes the receive thread even if there is only an AudioPacketInterceptor, but no ReceiveHandler.
I have tried to cleanup this setup routine as much as I could, but I would appreciate a second pair of eyes checking on it.
There was a problem hiding this comment.
With your changes, if there is a "consumer" but the socket is either null or closed, nothing happens.
In the old implementation, if the socket was null/closed (no matter if "consumer" is set, there was cleanup (your else branch)
There was a problem hiding this comment.
Thanks, I did not spot that!
I think it does not make a difference in this case tough, the combined audio thread only gets setup when the udpSocket is not null, so there is nothing to clean up.
|
This PR is on hold until voice resume has been merged. On a side note, you need to update your code style to fit into JDA, the wiki explains this. |
|
I have fixed the teardown and style issues |
MinnDevelopment
added
type: feature
status: freezer
|
I'm assigning this to @DV8FromTheWorld so he can decide how we should implement this. |
|
Closing this, so @DV8FromTheWorld can use the issue to decide on an implementation. This PR is not satisfying. |
Implemented a new interface for AudioPacketInterceptor.
This object can be registered just like an AudioReceiveHandler, but it provides a much more low level access to audio packets than the standard handleUserAudio callback.
Also allows discarding AudioPackets, effectively hiding them from the JDA backend.
This PR implements issue #418