fix: force focus on closing term prevents switching to other elements on a click

[mournfulCoroner]

When the term is open, any click outside the term returns the focus to the definition of the term, which interferes with the operation of interactive elements.
Example: for the first click on the input, the focus immediately goes off

terms.broken.mov

I suggest returning focus only for keydown event, since it is only needed in this case.

[martyanovandrey]

closeDefinition has only one usage here https://github.com/diplodoc-platform/transform/blob/master/src/js/term/index.ts#L28C13-L28C28 why this if (forceFocus) needed?

[mournfulCoroner]

There're some usages in utils.ts file (for example

transform/src/js/term/utils.ts

Line 154 in f10be7f

closeDefinition(openedDefinition);

)
I don't know why the search isn't detecting this.

[martyanovandrey]

Yeah, I see it now

Let's refactor the function a little then

let's add the function getTermByDefinition to utils.ts

function getTermByDefinition(definition: HTMLElement) {
    const termId = definition.getAttribute('term-id');

    return termId ? document.getElementById(termId) : null;
}

Use it in closeDefinition and remove focus management from it. And then we'll adjust the logic to:

if (event.key === 'Escape' && openedDefinition) {
    closeDefinition(openedDefinition);
    getTermByDefinition(openedDefinition)?.focus();
}

[martyanovandrey]

unfortunately, it seems that it will not be possible to take into account only the case if (event.key === 'Escape' && openedDefinition) {

in this case, if we close the term by clicking in the region without selecting a new active entity, then our focus completely flies off

[mournfulCoroner]

unfortunately, it seems that it will not be possible to take into account only the case if (event.key === 'Escape' && openedDefinition) {

in this case, if we close the term by clicking in the region without selecting a new active entity, then our focus completely flies off

But isn't this the standard browser behavior when clicking a mouse? If you click on an empty space, then the focus is lost.

[martyanovandrey]

indeed, it looks like the current focus return in terms was redundant and doesn't need to be saved