feat: add VersionsSelect component #375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visual Tests Report is ready. |
| @@ -0,0 +1,36 @@ | |||
| import React, {useCallback, useState} from 'react'; | |||
There was a problem hiding this comment.
It's worth adding the inclusion of version selection in the storybook with the main page
There was a problem hiding this comment.
- Added VersionsSelection in Controls component
- Updated DocPage for VersionsSelection
- Renamed VersionsSelection to VersionControl for naming consistency
- Added data for it in Storybook
- Refactored Controls component
- Add horizontal scroll for controls panel (overflow with VersionControl)
Tests failed because old screenshots don't contain VersionControl
Demo:
VersionControl.mov
Add typization for useTranslation hook
Rename to VersionControl. Move to Controls folder. Delete redudant re-export.
Extract creating control flags in separate function
Add left margin only for VersionControl Add divider after VersionControl only if Controls contains VersionControl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.