Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed base_mobile.html #35670

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Removed base_mobile.html #35670

merged 1 commit into from
Jan 23, 2025

Conversation

orangejenny
Copy link
Contributor

Technical Summary

The last reference to this was removed in #28516

Safety Assurance

Safety story

Removal of dead code. Code review is sufficient confirmation that it is truly dead.

Automated test coverage

no

QA Plan

no

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@orangejenny orangejenny added the product/invisible Change has no end-user visible impact label Jan 23, 2025
@orangejenny orangejenny requested a review from biyeun as a code owner January 23, 2025 16:07
jingcheng16
jingcheng16 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jingcheng16 jingcheng16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love removing code!

biyeun
biyeun approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@biyeun biyeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoa this is no longer used?? amazing!

@orangejenny orangejenny merged commit 4f78600 into master Jan 23, 2025
14 checks passed
@orangejenny orangejenny deleted the jls/kill-base-mobile-html branch January 23, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingcheng16 jingcheng16 jingcheng16 approved these changes

@biyeun biyeun biyeun approved these changes

@AmitPhulera AmitPhulera Awaiting requested review from AmitPhulera

@gherceg gherceg Awaiting requested review from gherceg

Assignees
No one assigned
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orangejenny @biyeun @jingcheng16