Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B5} update ChangeButtonState utility to support the 'reset' option #35658

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

biyeun
Copy link
Member

@biyeun biyeun commented Jan 22, 2025

Technical Summary

The original button() state change utility from Bootstrap 3 allowed for a "reset" option to be passed in which would change the button state back to what it was prior to any other state change. This implements that behavior, which is needed by reports.

Safety Assurance

Safety story

Very safe small change

Automated test coverage

N/A...diffs only

QA Plan

Not needed

Rollback instructions

unchecked due to diffs

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@biyeun biyeun added the product/invisible Change has no end-user visible impact label Jan 22, 2025
@biyeun biyeun requested review from orangejenny and a team January 22, 2025 17:44
@biyeun biyeun merged commit 56eef71 into master Jan 23, 2025
12 of 13 checks passed
@biyeun biyeun deleted the bmb/change-button-state-reset branch January 23, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants