[B5] Update core report modules to ESM format and fix datatables imports for bootstrap 5 #35656
+1,354
−483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejenny
approved these changes
Jan 22, 2025
|
@orangejenny interesting...tests are showing webpack build errors for bootstrap 3 files... |
|
Also, diffs are a reason why i didn't separate these out in the first place |
biyeun
force-pushed
the
bmb/b5-reports-esm
branch
from
92e5677 to
426a708
Compare
orangejenny
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Updates
base.js,tabular.jsanddatatables_config.jsto ESM formatSafety Assurance
Safety story
Safe change. Not used by any production pages (no bootstrap 5 reports yet)
Automated test coverage
N/A
QA Plan
Not needed
Rollback instructions
unchecking due to bootstrap 5 diffs. late reverts can cause issues.
Labels & Review