Only set CheckboxInputField for BooleanFields #35655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejenny
approved these changes
Jan 22, 2025
|
Confirmed this is working on staging too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
https://dimagi.atlassian.net/browse/SAAS-16481
Followup to #35550.
There is a non-boolean field input on this page that was impacted by all field widget's being set to a checkbox input, which made validation fail for this form any time a change was attempted, and therefore no changes could be made.
The field that is a non-boolean field is behind a feature flag, but still impacts form validation even when in a domain where the flag is not enabled.
Feature Flag
Safety Assurance
Safety story
Tested locally.
Automated test coverage
QA Plan
No
Rollback instructions
Labels & Review