Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coderabbit/config updates #35645

Merged
merged 7 commits into from
Jan 22, 2025
Merged
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions .coderabbit.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,25 @@
language: en-US
early_access: true
reviews:
high_level_summary: false
review_status: false
poem: false
collapse_walkthrough: true
changed_files_summary: false
abort_on_close: true
auto_review:
enabled: false
auto_incremental_review: false
drafts: true
high_level_summary: false
review_status: false
poem: false
changed_files_summary: false
abort_on_close: true
instructions: >-
- Consider the [code review](https://github.com/dimagi/open-source/blob/master/docs/code_review.md) and [contributing](https://github.com/dimagi/commcare-hq/blob/master/CONTRIBUTING.rst)
guides when doing a review.
- Also follow the [project standards and best practices](https://github.com/dimagi/commcare-hq/blob/master/STANDARDS.rst) guide.
path_instructions:
- path: "**/*.js"
instructions: >-
- Review the JavaScript code against the Google JavaScript style guide and point out any mismatches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a link to "Google JavaScript style guide"?

- Also follow [this guide](https://github.com/dimagi/commcare-hq/blob/master/docs/js-guide/code-review.rst)
- path: "**/*.py"
instructions: >-
- Review the code following best practises and standards
path_filters: ["**/*.js", "**/*.py", "**/*.md", "**/*.rst"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with making this opt-in. I think you could add HTML files here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML! Good catch!

auto_review:
enabled: false
auto_incremental_review: false
drafts: false
Loading