-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coderabbit/config updates #35645
Merged
+22
−10
Merged
Coderabbit/config updates #35645
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
99fe884
Disable draft reviews
Charl1996 58b516a
Add some instructions
Charl1996 c5ddabb
Remove walkthrough
Charl1996 282c803
Add path filters to only review certain types of files
Charl1996 be675dd
Be more explicit in config
Charl1996 c5c1dc5
Add HTML to path_filters
Charl1996 b2aa9d3
Add link to google js guide
Charl1996 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,25 @@ | ||
language: en-US | ||
early_access: true | ||
reviews: | ||
high_level_summary: false | ||
review_status: false | ||
poem: false | ||
collapse_walkthrough: true | ||
changed_files_summary: false | ||
abort_on_close: true | ||
auto_review: | ||
enabled: false | ||
auto_incremental_review: false | ||
drafts: true | ||
high_level_summary: false | ||
review_status: false | ||
poem: false | ||
changed_files_summary: false | ||
abort_on_close: true | ||
instructions: >- | ||
- Consider the [code review](https://github.com/dimagi/open-source/blob/master/docs/code_review.md) and [contributing](https://github.com/dimagi/commcare-hq/blob/master/CONTRIBUTING.rst) | ||
guides when doing a review. | ||
- Also follow the [project standards and best practices](https://github.com/dimagi/commcare-hq/blob/master/STANDARDS.rst) guide. | ||
path_instructions: | ||
- path: "**/*.js" | ||
instructions: >- | ||
- Review the JavaScript code against the Google JavaScript style guide and point out any mismatches | ||
- Also follow [this guide](https://github.com/dimagi/commcare-hq/blob/master/docs/js-guide/code-review.rst) | ||
- path: "**/*.py" | ||
instructions: >- | ||
- Review the code following best practises and standards | ||
path_filters: ["**/*.js", "**/*.py", "**/*.md", "**/*.rst"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with making this opt-in. I think you could add HTML files here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. HTML! Good catch! |
||
auto_review: | ||
enabled: false | ||
auto_incremental_review: false | ||
drafts: false |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a link to "Google JavaScript style guide"?