Merge pull request #35693 from dimagi/jls/app-manager-dependencies-gl…

…obals-only App manager js dependencies: jquery/knockout/underscore only
dimagi · Jan 28, 2025 · 5fe1480 · 5fe1480
2 parents d9e337a + 59fb2da
commit 5fe1480
Show file tree

Hide file tree

Showing 6 changed files with 35 additions and 10 deletions.
diff --git a/corehq/apps/app_manager/static/app_manager/js/details/filter.js b/corehq/apps/app_manager/static/app_manager/js/details/filter.js
@@ -1,3 +1,8 @@
+hqDefine("app_manager/js/details/filter", [
+    "knockout",
+], function (
+    ko,
+) {
 /**
  * Model for the case list filter, which has a button to
  * "Add Filter" when there's no filter, and when clicked
@@ -6,7 +11,6 @@
  * @param filterText Initial text of the filter
  * @param saveButton Save button for case list config
  */
-hqDefine("app_manager/js/details/filter", function () {
     return function (filterText, saveButton) {
         var self = {};
         self.filterText = ko.observable(typeof filterText === "string" && filterText.length > 0 ? filterText : "");

diff --git a/corehq/apps/app_manager/static/app_manager/js/details/fixture_select.js b/corehq/apps/app_manager/static/app_manager/js/details/fixture_select.js
@@ -1,7 +1,11 @@
 /**
  * Model for Lookup Table Case Selection in case list configuration.
  */
-hqDefine("app_manager/js/details/fixture_select", function () {
+hqDefine("app_manager/js/details/fixture_select", [
+    "knockout",
+], function (
+    ko,
+) {
     return function (init) {
         var self = {};
         self.active = ko.observable(init.active);
@@ -17,4 +21,4 @@ hqDefine("app_manager/js/details/fixture_select", function () {
         });
         return self;
     };
-});
+});
diff --git a/corehq/apps/app_manager/static/app_manager/js/forms/custom_instances.js b/corehq/apps/app_manager/static/app_manager/js/forms/custom_instances.js
@@ -1,7 +1,8 @@
-"use strict";
-hqDefine('app_manager/js/forms/custom_instances', function () {
-    'use strict';
-
+hqDefine("app_manager/js/forms/custom_instances", [
+    "knockout",
+], function (
+    ko,
+) {
     var customInstance = function (instanceId, instancePath) {
         var self = {};
         self.instanceId = ko.observable(instanceId || '');

diff --git a/corehq/apps/app_manager/static/app_manager/js/modules/case_list_setting.js b/corehq/apps/app_manager/static/app_manager/js/modules/case_list_setting.js
@@ -1,4 +1,10 @@
-hqDefine("app_manager/js/modules/case_list_setting", function () {
+hqDefine("app_manager/js/modules/case_list_setting", [
+    'jquery',
+    'underscore',
+], function (
+    $,
+    _
+) {
     function getLabel(slug) { return $('.case-list-setting-label[data-slug="' + slug + '"]'); }
     function getShow(slug) { return $('.case-list-setting-show[data-slug="' + slug + '"]'); }
     function getMedia(slug) { return $('.case-list-setting-media[data-slug="' + slug + '"]'); }

diff --git a/corehq/apps/app_manager/static/app_manager/js/modules/shadow_module_settings.js b/corehq/apps/app_manager/static/app_manager/js/modules/shadow_module_settings.js
@@ -1,4 +1,10 @@
-hqDefine('app_manager/js/modules/shadow_module_settings', function () {
+hqDefine('app_manager/js/modules/shadow_module_settings', [
+    'knockout',
+    'underscore',
+], function (
+    ko,
+    _,
+) {
     const module = {
 
         /**

diff --git a/corehq/apps/app_manager/static/app_manager/js/section_changer.js b/corehq/apps/app_manager/static/app_manager/js/section_changer.js
@@ -32,7 +32,11 @@
 
  *  When the user shows or hides a section, that preference is stored in localStorage.
  */
-hqDefine("app_manager/js/section_changer", function () {
+hqDefine("app_manager/js/section_changer", [
+    'jquery',
+], function (
+    $
+) {
     // Determine key for localStorage
     // page is something like "module-view"
     // section is something like "logic"