Fix Case detail tab title

[avazirna]

Product Description

This PR fixes an issue in the Case details which causes a mismatch between tab items and their respective content when a display condition is set. The fix is basically to restore a method that was removed during the migration to ViewPager2 that retrieves the title of the page from the visible tabs.

Ticket: https://dimagi.atlassian.net/browse/SAAS-16528

Safety Assurance

Safety story

This was tested locally and with different configurations, all seems fine.

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes introduce a new public method in the EntityDetailPagerAdapter class that returns the title for a given page based on whether the detail is compound. The method, getPageTitle(int position), evaluates the text from the associated detail’s title. Furthermore, the TabbedDetailView class was updated to use this new method instead of directly calling the evaluation on the detail object. A minor formatting adjustment was also applied to improve code readability.

Sequence Diagram(s)

sequenceDiagram
    participant TDV as TabbedDetailView
    participant ADP as EntityDetailPagerAdapter
    participant D as Detail Object

    TDV->>ADP: refresh() calls getPageTitle(position)
    ADP->>D: Determine title (compound check)
    D-->>ADP: Return evaluated title text
    ADP-->>TDV: Return page title

Loading

Possibly related PRs

• Update pull_request_template.md #2946: Involves changes related to the addition of the getPageTitle method and its usage in managing tab titles.
• Change progress dialog cancel button visibility state #2929: Contains modifications in UI components for setting and displaying titles, directly related to these changes.
• Migrate to ViewPager2 #2873: Focuses on the implementation of title retrieval logic in the adapter, which is utilized in the updated tab view.

Suggested labels

QA Note, skip-integration-tests

Suggested reviewers

• OrangeAndGreen
• shubham1g5

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8323e54 and b060e6f.

📒 Files selected for processing (2)

• app/src/org/commcare/adapters/EntityDetailPagerAdapter.java (2 hunks)
• app/src/org/commcare/views/TabbedDetailView.java (1 hunks)

🔇 Additional comments (2)

app/src/org/commcare/adapters/EntityDetailPagerAdapter.java (1)

62-65: LGTM! The implementation correctly handles both compound and non-compound details.

The method safely retrieves the appropriate detail object and evaluates its title text. The implementation is thread-safe and handles all cases correctly.

app/src/org/commcare/views/TabbedDetailView.java (1)

89-89: LGTM! The change correctly delegates tab title retrieval to the adapter.

The implementation properly uses the new getPageTitle method, which fixes the mismatch between tab items and their content when a display condition is applied.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[shubham1g5]

is there a reason this method is here and not in TabbedDetailView itself ?