Pass query params to HTTP requests that don't require authentication #2793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue that is causing the
app_id
in the response body of the Recovery Measures GET request to benull
.In CommCareHQ, the
app_id
is added to the response body from the GET request itself, from a query param, and because the existing logic that builds HTTP requests for requests that don't need authentication is ignoring any params that have been passed, theapp_id
is not part of the request, causing it to benull
in the response body. With theapp_id
logic not present the Recovery Measures are not being triggered when they should.cross-request: dimagi/commcare-core#1422
Ticket: https://dimagi.atlassian.net/browse/QA-6606
Safety Assurance
Safety story
This only passes query params for HTTP requests without auth