Gradle 8 updates #2669

shubham1g5 · 2023-05-04T17:13:23Z

cross-request: dimagi/commcare-core#1277

shubham1g5 · 2023-05-05T14:35:51Z

This will need more work to resolve Kotlin compilation errors due to us using a non compile time constant in Kotlin files like - @ManagedUi(R.layout.http_request_layout). We will probably need some other mechanism to initialise the managed UIs like standardising a public method to get the layout instead and then use method reflection to get the layout value instead.

fun getLayoutResource() : int { return R.layout.http_request_layout}

avazirna · 2023-09-14T12:42:59Z

@shubham1g5 should we plan this for 2.55?

shubham1g5 · 2023-09-14T12:51:44Z

should we plan this for 2.55?

yes

avazirna · 2024-03-04T14:26:57Z

@damagatchi retest this please

avazirna · 2024-03-18T13:06:44Z

From Gradle 8.0, R classes are generated with non-final fields by default, this can be prevented by setting the flag to false.

avazirna · 2024-03-18T13:38:23Z

@damagatchi retest this please

…ndencies From Gradle 8.0, R classes are non transitive by defaut, so when referencing from other modules/dependencies it's required their fully qualified classe name OR switch off the flag

avazirna · 2024-03-18T17:46:59Z

@damagatchi retest this please

avazirna · 2024-03-19T11:09:25Z

@damagatchi retest this please

shubham1g5 · 2024-03-19T21:14:57Z

app/test-proguard.cfg

@@ -0,0 +1,15 @@
+-dontwarn com.sun.javadoc.**


should the proguard rules for test be same as prod ?

My understanding is that, in previous version, ProGuard rules were mostly applied to production apks, very little (if any) optimizations to test apks. Gradle 8 with R8 in fullMode by default changed that, so now we also need specific rules for the tests apk.

but should not the test apk should have the same set of rules as prod apk ?

Or curious how did we came up with these rules ?

from the missing_rules file after a failed build. Here's a snippet of the report:

Missing class com.sun.javadoc.Doc (referenced from: java.lang.String org.checkerframework.org.plumelib.options.OptionsDoclet.javadocToHtml(com.sun.javadoc.Doc) and 3 other contexts) Missing class com.sun.javadoc.DocErrorReporter (referenced from: boolean org.checkerframework.org.plumelib.options.OptionsDoclet.validOptions(java.lang.String[][], com.sun.javadoc.DocErrorReporter)) Missing class com.sun.javadoc.FieldDoc (referenced from: void org.checkerframework.org.plumelib.options.OptionsDoclet.processEnumJavadoc(org.checkerframework.org.plumelib.options.Options$OptionInfo) and 1 other context) Missing class com.sun.javadoc.RootDoc (referenced from: com.sun.javadoc.RootDoc org.checkerframework.org.plumelib.options.OptionsDoclet.root and 5 other contexts) Missing class com.sun.javadoc.SeeTag (referenced from: java.lang.String org.checkerframework.org.plumelib.options.OptionsDoclet.javadocToHtml(com.sun.javadoc.Doc)) Missing class com.sun.javadoc.Tag (referenced from: java.lang.String org.checkerframework.org.plumelib.options.OptionsDoclet.javadocToHtml(com.sun.javadoc.Doc)) Missing class com.sun.source.tree.AnnotatedTypeTree (referenced from: java.lang.Boolean annotator.find.ASTPathCriterion$1.visitAnnotatedType(com.sun.source.tree.AnnotatedTypeTree, com.sun.source.tree.Tree) and 26 other contexts) Missing class com.sun.source.tree.AnnotationTree (referenced from: boolean annotator.find.TreeFinder.alreadyPresent(com.sun.source.util.TreePath, annotator.find.Insertion) and 27 other contexts) Missing class com.sun.source.tree.ArrayAccessTree (referenced from: com.sun.source.tree.Tree annotator.find.ASTPathCriterion.getNext(com.sun.source.tree.Tree, scenelib.annotations.io.ASTPath, int) and 28 other contexts) Missing class com.sun.source.tree.ArrayTypeTree (referenced from: com.sun.source.tree.ArrayTypeTree org.checkerframework.dataflow.cfg.node.ArrayTypeNode.tree and 29 other contexts) Missing class com.sun.source.tree.AssertTree (referenced from: com.sun.source.tree.Tree annotator.find.ASTPathCriterion.getNext(com.sun.source.tree.Tree, scenelib.annotations.io.ASTPath, int) and 13 other contexts) Missing class com.sun.source.tree.AssignmentTree (referenced from: com.sun.source.tree.Tree annotator.find.ASTPathCriterion.getNext(com.sun.source.tree.Tree, scenelib.annotations.io.ASTPath, int) and 23 other contexts) Missing class com.sun.source.tree.BinaryTree (referenced from: com.sun.source.tree.BinaryTree org.checkerframework.checker.interning.InterningVisitor$2.val$node and 98 other contexts)

shubham1g5 · 2024-03-19T21:16:48Z

app/proguard.cfg

@@ -102,6 +104,7 @@
 -dontnote okhttp3.**

 #Retrofit Stuff
+-keep class retrofit2.** { *; }


How does Gradle update affect proguard rules ?

Gradle 8 is on full mode by default, which means more aggressive optimizations. In this case, it was causing IllegalArgumentExceptions with the message Call return type must be parameterized as Call<Foo> or Call<? extends Foo> during get requests, which made me suspect that maybe some references had been obfuscated. After some digging, I found some posts that pointed that way too.

got it, although I don't think it's a good practice to retain all code from a package. Probably we should instead take the rules from here

looks like this is still pending.

yes, just pushed that also

shubham1g5 · 2024-04-12T07:30:58Z

@avazirna checking if you are stuck on something with this ?

avazirna · 2024-04-12T11:08:18Z

@avazirna checking if you are stuck on something with this ?

Nothing, all good. Let me just check why did the build fail.

avazirna · 2024-04-12T11:38:16Z

@damagatchi retest this please

avazirna · 2024-04-12T13:19:15Z

@damagatchi retest this please

avazirna · 2024-04-12T13:35:50Z

@damagatchi retest this please

avazirna · 2024-04-12T13:44:32Z

@damagatchi retest this please

avazirna · 2024-04-12T15:30:45Z

@damagatchi retest this please

shubham1g5 · 2024-04-13T04:13:19Z

Great, looks good to merge to me as well.

shubham1g5 added cross requested product/invisible labels May 4, 2023

shubham1g5 added this to the 2.54 milestone May 4, 2023

shubham1g5 modified the milestones: 2.54, 2.55 Sep 14, 2023

shubham1g5 mentioned this pull request Sep 25, 2023

[duplicate] Gradle 8 dimagi/commcare-core#1277

Merged

Gradle 8 updates

df47768

avazirna force-pushed the gradle8 branch from 4bfce8b to df47768 Compare March 18, 2024 12:58

Flag gradle to generate R classes with final fields

de95c12

avazirna added 2 commits March 18, 2024 19:09

Set fully qualified class names for resources from other modules/depe…

f10bc2e

…ndencies From Gradle 8.0, R classes are non transitive by defaut, so when referencing from other modules/dependencies it's required their fully qualified classe name OR switch off the flag

Remove package from instrumentation tests manifest file

ffe2634

avazirna force-pushed the gradle8 branch from 6b30e8e to 4309dd8 Compare March 19, 2024 12:10

avazirna added 2 commits March 19, 2024 15:01

Update ProgGuard rules

5086ef2

Add ProGuard rules for tests

4fc5e22

avazirna force-pushed the gradle8 branch from 4309dd8 to 4fc5e22 Compare March 19, 2024 13:02

Lint

949ef0f

avazirna force-pushed the gradle8 branch from 895ca28 to 949ef0f Compare March 19, 2024 16:28

shubham1g5 commented Mar 19, 2024

View reviewed changes

avazirna self-requested a review March 20, 2024 07:02

avazirna previously approved these changes Apr 12, 2024

View reviewed changes

avazirna added 2 commits April 12, 2024 15:07

Detail Proguard definitions

c3462c5

Lint

c379d44

avazirna dismissed their stale review via c379d44 April 12, 2024 13:11

avazirna force-pushed the gradle8 branch from ca46485 to c379d44 Compare April 12, 2024 13:11

avazirna approved these changes Apr 17, 2024

View reviewed changes

avazirna merged commit b2a3665 into master Apr 17, 2024
4 of 8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gradle 8 updates #2669

Gradle 8 updates #2669

shubham1g5 commented May 4, 2023

shubham1g5 commented May 5, 2023 •

edited

Loading

avazirna commented Sep 14, 2023

shubham1g5 commented Sep 14, 2023

avazirna commented Mar 4, 2024

avazirna commented Mar 18, 2024

avazirna commented Mar 18, 2024

avazirna commented Mar 18, 2024

avazirna commented Mar 19, 2024

shubham1g5 Mar 19, 2024

avazirna Mar 20, 2024

shubham1g5 Mar 20, 2024

shubham1g5 Mar 20, 2024

avazirna Apr 8, 2024

shubham1g5 Mar 19, 2024

avazirna Mar 20, 2024 •

edited

Loading

shubham1g5 Mar 20, 2024

avazirna Mar 27, 2024

shubham1g5 Apr 12, 2024

avazirna Apr 12, 2024

shubham1g5 commented Apr 12, 2024

avazirna commented Apr 12, 2024

avazirna commented Apr 12, 2024

avazirna commented Apr 12, 2024

avazirna commented Apr 12, 2024

avazirna commented Apr 12, 2024

avazirna commented Apr 12, 2024

shubham1g5 commented Apr 13, 2024

Gradle 8 updates #2669

Gradle 8 updates #2669

Conversation

shubham1g5 commented May 4, 2023

shubham1g5 commented May 5, 2023 • edited Loading

avazirna commented Sep 14, 2023

shubham1g5 commented Sep 14, 2023

avazirna commented Mar 4, 2024

avazirna commented Mar 18, 2024

avazirna commented Mar 18, 2024

avazirna commented Mar 18, 2024

avazirna commented Mar 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

avazirna Mar 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shubham1g5 commented Apr 12, 2024

avazirna commented Apr 12, 2024

avazirna commented Apr 12, 2024

avazirna commented Apr 12, 2024

avazirna commented Apr 12, 2024

avazirna commented Apr 12, 2024

avazirna commented Apr 12, 2024

shubham1g5 commented Apr 13, 2024

shubham1g5 commented May 5, 2023 •

edited

Loading

avazirna Mar 20, 2024 •

edited

Loading