Shifts Kujaku to download from github packages #2475
Conversation
| name = "GitHubPackages" | ||
| url = uri("https://maven.pkg.github.com/onaio/kujaku") | ||
| credentials { | ||
| username = githubProperties['gpr.usr'] ?: System.getenv("GPR_USER") |
There was a problem hiding this comment.
System.getenv("GPR_USER") is getting value from jenkins job config right?
If yes, Should we rather use gradle.properties here, since creating new jobs in jenkins would require adding this property.
There was a problem hiding this comment.
good point, will update.
|
Oof, this is a really rough change. This adds a new dependency where anyone downloading the codebase needs a github packages PAT? Have we asked the Kujaku project maintainers to change that? I think this calls the dependency into question. |
|
@ctsims that's true unfortunately, though I think Github Packages is a temporary workaround from them until they are able to migrate to maven central. @ekigamba Wondering if you will be open to shift to more open artifact managers like Jitpack for example as I assume migrating to maven central will take some time for you. |
|
@ctsims @shubham1g5 Github packages is a temporary solution for now. We are open to any other artifact manager that is easy to integrate. We are open to any suggestions on the issue onaio/kujaku#352 |
|
Closing in favour of #2481 |
#2473
onaio/kujaku#352 (comment)
This will require devs to generate a personal access token from github and add github.properties