1945: Unit test card search params #1947
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1sh1918
force-pushed
the
1945-unit-test-card-search-params
branch
from
affc752 to
aea1fc0
Compare
f1sh1918
requested review from
steffenkleinle,
ztefanie and
seluianova
as code owners
f1sh1918
commented
Feb 26, 2025
administration/src/bp-modules/cards/hooks/useCardGenerator.test.tsx
Outdated
Show resolved
Hide resolved
steffenkleinle
approved these changes
Feb 28, 2025
administration/src/bp-modules/cards/hooks/useCardGenerator.test.tsx
Outdated
Show resolved
Hide resolved
administration/src/bp-modules/cards/hooks/useCardGenerator.test.tsx
Outdated
Show resolved
Hide resolved
administration/src/bp-modules/cards/hooks/useCardGenerator.test.tsx
Outdated
Show resolved
Hide resolved
I moved the test for koblenz to the selfService hook. Not sure if we need both tests, since normal card creation is disabled for koblenz. I dunno how i should test this applicationId since it will not be set in the cards object. |
f1sh1918
force-pushed
the
1945-unit-test-card-search-params
branch
from
12ef720 to
9b1ff72
Compare
Comment on lines
+33
to
+49
| const wrapper = ({ children, initialRoutes }: { children: ReactNode; initialRoutes?: string[] }) => ( | ||
| <MemoryRouter initialEntries={initialRoutes}> | ||
| <AppToasterProvider> | ||
| <MockedProvider mocks={mocks} addTypename={false}> | ||
| <ProjectConfigProvider projectConfig={koblenzConfig}>{children}</ProjectConfigProvider> | ||
| </MockedProvider> | ||
| </AppToasterProvider> | ||
| </MemoryRouter> | ||
| ) | ||
|
|
||
| const withCustomWrapper = | ||
| (initialRoute: string) => | ||
| ({ children }: { children: ReactNode }) => | ||
| wrapper({ | ||
| children, | ||
| initialRoutes: [initialRoute], | ||
| }) |
There was a problem hiding this comment.
🙃 I guess we should make this reusable at some point to a shared testing file.
There was a problem hiding this comment.
Yes feel free to add a task for this
You could mock the mutation and ensure that it was called with the application id from the query params. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Add unit tests for correctly initializing cards with searchParams.
Proposed Changes
Side Effects
Testing
N/A
Resolved Issues
Fixes: #1945