1762: Add agency information to region #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate a separate table for these information, add a relation between those tables
f1sh1918
requested review from
steffenkleinle,
ztefanie and
seluianova
as code owners
f1sh1918
force-pushed
the
1762-add-agency-id-to-region
branch
from
89f3c49 to
1add00b
Compare
f1sh1918
force-pushed
the
1762-add-agency-id-to-region
branch
from
1add00b to
a24d89f
Compare
backend/src/main/kotlin/app/ehrenamtskarte/backend/regions/database/Setup.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/regions/database/Setup.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/regions/database/Setup.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/regions/database/Setup.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/freinet/database/Schema.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/freinet/database/Setup.kt
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/freinet/util/FreinetAgenciesLoader.kt
Outdated
Show resolved
Hide resolved
...d/src/main/kotlin/app/ehrenamtskarte/backend/freinet/webservice/FreinetAgencyQueryService.kt
Show resolved
Hide resolved
...c/main/kotlin/app/ehrenamtskarte/backend/freinet/webservice/schema/types/FreinetApiAgency.kt
Outdated
Show resolved
Hide resolved
steffenkleinle
requested changes
Feb 26, 2025
...nd/src/main/kotlin/app/ehrenamtskarte/backend/freinet/webservice/schema/types/XMLAgencies.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/freinet/webservice/schema/types/XMLAgency.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/freinet/util/FreinetAgenciesLoader.kt
Outdated
Show resolved
Hide resolved
I know. but thats what we got from freinet. You can tell them your concern about security issues |
steffenkleinle
approved these changes
Feb 26, 2025
andrew8er
approved these changes
Feb 26, 2025
backend/src/main/kotlin/app/ehrenamtskarte/backend/auth/service/Authorizer.kt
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/config/BackendConfiguration.kt
Show resolved
Hide resolved
...src/main/kotlin/app/ehrenamtskarte/backend/freinet/database/repos/FreinetAgencyRepository.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/freinet/util/FreinetAgenciesLoader.kt
Outdated
Show resolved
Hide resolved
...d/src/main/kotlin/app/ehrenamtskarte/backend/freinet/webservice/FreinetAgencyQueryService.kt
Outdated
Show resolved
Hide resolved
...d/src/main/kotlin/app/ehrenamtskarte/backend/freinet/webservice/FreinetAgencyQueryService.kt
Outdated
Show resolved
Hide resolved
...d/src/main/kotlin/app/ehrenamtskarte/backend/freinet/webservice/FreinetAgencyQueryService.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/app/ehrenamtskarte/backend/migration/migrations/V0026_AddFreinetAgenciesTable.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/regions/database/Setup.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/regions/database/Setup.kt
Outdated
Show resolved
Hide resolved
Thanks for the great review. I think i addressed all comments. |
andrew8er
approved these changes
Feb 27, 2025
...main/kotlin/app/ehrenamtskarte/backend/migration/migrations/V0026_AddFreinetAgenciesTable.kt
Outdated
Show resolved
Hide resolved
f1sh1918
force-pushed
the
1762-add-agency-id-to-region
branch
from
16c6560 to
9cb5b39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Here we add required agency information from freinet to our regions. We need the
agencyIdandaccessKeyto push applicant and card data to freinet in a separate issueProposed changes
Note
Here is a separate pr to provide backend config and the freinet api access key on the server
https://git.tuerantuer.org/DF/salt/pulls/309/files
Frontend implementation will be done in #1899
Side effects
Testing
config.local.ymlYou can find the accessKey here: https://passbolt.tuerantuer.org/app/passwords/view/0b693665-7176-4524-a6dd-206fad7c4d8d
Resolved issues
Fixes: #1762