Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add at risk section #49

Merged
merged 20 commits into from
Sep 27, 2024
Merged

Add at risk section #49

merged 20 commits into from
Sep 27, 2024

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Sep 13, 2024

Features:

  1. Adds a new At Risk Matrix to the end of the report.
  2. Removes opacity filter from at risk rows
  3. Adds an orange warning outline to at risk rows
  4. does not consider rows where all tests were skipped as at risk
  5. does not consider matrices with titles including (interop) for at risk section
  6. removes duplicate test titles

This has been tested with:

  • VC 2.0 Suite
  • ECDSA Suite
  • BBS Suite
  • EDDSA Suite

@aljones15 aljones15 self-assigned this Sep 13, 2024
@@ -17,7 +17,7 @@
</thead>
<tbody>
{{#each matrix.rows}}
<tr class={{atRisk cells}}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine if we keep these here. I just didn't want that to be the only way to find them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because At Risk is just another matrix it results in all of the rows in At Risk having opacity 0.6 so I think it's better just to do the At Risk section or change the way at risk rows are highlighted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed this with a thin outline: 130d0d5

@aljones15
Copy link
Contributor Author

aljones15 commented Sep 18, 2024

Screenshot 2024-09-18 at 5 16 33 PM @BigBlueHat take a look at the latest

NOTE: text was changed to At least 2 passing implementations

@aljones15 aljones15 mentioned this pull request Sep 19, 2024
@aljones15 aljones15 changed the base branch from highlight-less-than-2 to main September 19, 2024 14:04
@aljones15 aljones15 marked this pull request as ready for review September 19, 2024 17:44
@BigBlueHat BigBlueHat merged commit fa50a71 into main Sep 27, 2024
3 checks passed
@BigBlueHat BigBlueHat deleted the add-at-risk-section branch September 27, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants