-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ecdsa-rdfc-2019
, eddsa-rdfc-2022
and ecdsa-sd-2023
to supported cryptosuites.
#55
Conversation
@dlongley The verification tests for VC signed with ecdsa-sd-2023 is currently failing, this is the error I am getting https://gist.github.com/JSAssassin/91efb24233792093b7a459893cac4c8f. Could you please guide me on how I can generate a derived proof? Does I also want to point out that the older credentials using |
@JSAssassin, I'll respond out of band on some of the questions above for quicker discussion. |
f44ecb9
to
f1b018f
Compare
legacy `ecdsa-2019` and `eddsa-2022` cryptosuites.
NOTE: All tests are passing locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving -- but some peer deps that were removed as unnecessary need to be added back. I'm not sure what tool / command is being used to determine whether those are needed or not -- but it's probably failing us in some way. Those packages are required peer dependencies.
"@bedrock/meter": "^5.0.0", | ||
"@bedrock/meter-http": "^12.0.0", | ||
"@bedrock/meter-usage-reporter": "^9.0.0", | ||
"@bedrock/mongodb": "^10.0.0", | ||
"@bedrock/multikey-context": "^2.0.0", | ||
"@bedrock/oauth2-verifier": "^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a required peer dependency of @bedrock/service-core
so it should not be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted back the test deps removal here fd3bbbe. Not sure why but when I used npx depcheck
it flagged @bedrock/service-core
and @bedrock/ledger-context
as unused packages and removal of those packages didn't cause any issues during installation or when running test.
No description provided.