Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ECDSA P-384 key type #50

Merged
merged 18 commits into from
Nov 6, 2023
Merged

Add support for ECDSA P-384 key type #50

merged 18 commits into from
Nov 6, 2023

Conversation

JSAssassin
Copy link
Contributor

@JSAssassin JSAssassin commented Aug 9, 2023

TODO: Update @digitalbazaar/ecdsa-2019-cryptosuite to released version in package.json.

@JSAssassin JSAssassin changed the title Add support for ECDSA P-384 key type Add support for ECDSA P-384 key type Aug 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #50 (dd6891c) into main (6cdedae) will increase coverage by 0.20%.
The diff coverage is 98.18%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   93.76%   93.97%   +0.20%     
==========================================
  Files           8        9       +1     
  Lines         850      896      +46     
==========================================
+ Hits          797      842      +45     
- Misses         53       54       +1     
Files Changed Coverage Δ
lib/suites.js 96.15% <94.44%> (-1.41%) ⬇️
lib/helpers.js 100.00% <100.00%> (ø)
lib/http.js 95.39% <100.00%> (+0.07%) ⬆️

lib/helpers.js Outdated Show resolved Hide resolved
lib/http.js Outdated Show resolved Hide resolved
lib/suites.js Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
## 18.1.0 - 2023-08-TBD

### Added
- Add support for verifying signatures that uses `ECDSA P-384` key type.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Add support for verifying signatures that uses `ECDSA P-384` key type.
- Add support for verifying signatures that use the `ECDSA P-384` key type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated c4c5d69

lib/http.js Outdated Show resolved Hide resolved
@JSAssassin JSAssassin requested a review from dlongley November 6, 2023 16:21
@dlongley dlongley merged commit 7dc6eb2 into main Nov 6, 2023
2 of 4 checks passed
@dlongley dlongley deleted the add-p-384-support branch November 6, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants